[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasec
From: |
ebik |
Subject: |
Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp |
Date: |
Wed, 28 Jan 2009 09:31:17 +0100 |
On Tue, 27 Jan 2009 23:02:52 -0500
Pavel Roskin <address@hidden> wrote:
> P.S. The reuse would be impractical. fs_uuid is a separate module,
> not the core. Reusing search_fs_uuid() would make the "search" module
> depend on "fs_uuid". In my opinion, it's not worth the trouble to
> introduce that dependency. It's not like we would save a lot of code.
Inlining or macro may be considered at that point. (I.e., reusing code
via .h file.) If someone will try to change such function (e.g., to
provide HisNewFs) then he need not to patch two places.
--
Tomáš 'ebík' Ebenlendr
http://get.to/ebik
PF 2009.07504223744
- [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Daniel Mierswa, 2009/01/21
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/21
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Daniel Mierswa, 2009/01/23
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/26
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Daniel Mierswa, 2009/01/26
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/27
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/27
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp,
ebik <=