Re: [PATCH] hdparm.mod - get/set ATA disk parameters

[Robert Millan]

On Sat, Feb 07, 2009 at 11:46:39PM +0100, Christian Franke wrote:
> Robert Millan wrote:
> >On Sat, Jan 24, 2009 at 11:59:01PM +0100, Christian Franke wrote:
> >  
> >>This patch adds a command which allows to change a few (S)ATA drive 
> >>settings. It relies on a new pass-through function in ata.mod.
> >>    
> >
> >Is this function going to be used for "normal" use of ata?  Note that 
> >ata.mod
> >should be as small as possible, since coreboot users usually want to 
> >include
> >it the GRUB that is installed to flash.
> >
> >  
> 
> Like 'hdparm.mod' itself, the ATA pass-through function is not needed 
> for normal boot.

Well, I know it's not needed, but I was wondering if there's the possibility
that other functions in ata.mod could start using it later on, or so.

> I would suggest to move grub_ata_pass_through() to a new module (e.g. 
> ata2.mod, atax.mod, ataex.mod, ...)

How about ata_something.mod?  (consistent with ntfs.mod & ntfs_comp.mod)

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."