Re: [PATCH] fix usability problem in FreeBSD loader

[Robert Millan]

Committed.

On Sat, Aug 01, 2009 at 04:28:52PM +0200, Robert Millan wrote:
> On Sat, Aug 01, 2009 at 03:49:15PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan<address@hidden> wrote:
> > >
> > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs
> > > freebsd_module first, the error message is confusing.
> > >
> > -static int kernel_type;
> > +static int kernel_type; /* 0 == KERNEL_TYPE_NONE */
> > I would prefer either
> > static int kernel_type = KERNEL_TYPE_NONE;
> 
> Ok.
> 
> > And it would be better to use an enum here rather than defines.
> 
> I'll fix that too.
> 
> > +                      "You need to load the kernel first.");
> > +
> >    if (kernel_type != KERNEL_TYPE_FREEBSD)
> >      return grub_error (GRUB_ERR_BAD_ARGUMENT,
> >                        "only freebsd support module");
> > It seems that we have a bitrot in error message styles. We should
> > agree on one style and use it everywhere
> 
> This error message, in particular, is copied from linux.c.  I think we
> should capitalize the first letter of a phrase every time.  I'll fix
> the other messages in this file too.
> 
> -- 
> Robert Millan
> 
>   The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>   how) you may access your data; but nobody's threatening your freedom: we
>   still allow you to remove your data and not access it at all."
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
> 

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."