Re: [PATCH] Fix locale installation

[Carles Pina i Estany]

Hello,

On Mar/19/2010, Colin Watson wrote:
> (cpina, if you're reading, I'd particularly appreciate your review.)

Here I am

> As far as I can see, locale installation is just wrong right now.

I cannot test it easily now.

I'll comment the new thing forgetting about the old one (doesn't look
right)

>  # Copy gettext files
>  mkdir -p ${grubdir}/locale/
> -for file in ${grubdir}/locale/*.mo ${pkglibdir}/locale/*.mo; do
> -    if test -f "$file"; then
> -        cp -f "$file" ${grubdir}/locale/
> +for dir in ${localedir}/*; do
> +    if test -f "$dir/LC_MESSAGES/grub.mo"; then
> +        cp -f "$dir/LC_MESSAGES/grub.mo" "${grubdir}/locale/${dir##*/}.mo"
>      fi
>  done

(I'll use shell variables in a bit "on my own way")

AFAIK the files are in po/$lang.{po,mo}, right? (at least in
my system without using another directory for the building, I need to
look in the other issue soon)

I thought that make install was copying from po/$lang.mo to
/usr/share/locale/$lang/LC_MESSAGES/grub.mo, but you are copying already
from some structure in $localedir/LC_MESSAGES/grub.mo. What am I missing?

It has been a while that I have not done these things, so sorry to be
more an "askwer" than "answerer".

-- 
Carles Pina i Estany
        http://pinux.info