[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Testcase for checking lvm module
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] Testcase for checking lvm module |
|
Date: |
Fri, 09 Apr 2010 15:50:24 +0200 |
|
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20091109) |
BVK Chaitanya wrote:
> Attached!
>
>
>
+size=128M
+disk1=`mktemp`
+disk2=`mktemp`
Plain mktemp will fail on FreeBSD. Idk for well freebsd supports linux lvm
though
+lvm=/sbin/lvmn
+parted=/sbin/parted
+losetup=/sbin/losetup
You don't check for real existence of these files. And letting use $PATH is
better IMO than hardcoding path to executables
+if test `id -u` != "0"; then
+ exit 0
+fi
+
There should be a warning here
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature