Re: Migrations to xorriso

[Colin Watson]

On Wed, May 19, 2010 at 02:01:50PM +0200, Thomas Schmitt wrote:
> would the following changes be acceptable for
> grub-mkrescue ?
> 
> - Option  --xorriso=PROGFILE  allows to use a
>   particular binary as xorriso program.
>   This will avoid the need to install xorriso.
>   One can just unpack and build it in some
>   directory and use .../xorriso/xorriso
>   as binary.

This is in line with other options already in GRUB utility scripts, so
seems sensible.

> - Option --diet saves about 400 kB of image
>   size without losing much benefit.

I don't have much of an opinion on this; but if it doesn't lose much,
why would it not be the default?  Or, put another way, why would
somebody want to turn this option off?

> +    "${xorriso}" -report_about HINT -as mkisofs -graft-points -no-pad 
> ${grub_mkisofs_arguments} --protective-msdos-label -r ${iso9660_dir} 
> ${source} | cat >"${output_image}"

Useless use of cat.

-- 
Colin Watson                                       address@hidden