Re: Bug#607867: grub-common: shouty "XEN" in menu items

[Colin Watson]

On Thu, Dec 23, 2010 at 09:23:15AM +0000, Ian Campbell wrote:
> update-grub currently produces menu items like:
>       'Debian GNU/Linux, with Linux 2.6.32-5-xen-amd64 and XEN 4.0-amd64'
> 
> There is no reason to capitalise Xen in that way and IMHO it looks strange.
> 
> The attached patch switches to:
>       'Debian GNU/Linux, with Xen 4.0-amd64 and Linux 2.6.32-5-xen-amd64'
> 
> I moved Xen first since I think it makes it clearer that a given menu item
> launches Xen, which is useful information to put up front. Also I found that
> with the long Linux version numbers Debian uses the Xen was very nearly off 
> the
> edge of the screen.

Makes sense to me.  Vladimir, you wrote this script - do you agree?

Could you please provide a ChangeLog entry for upstream?

> Although the string is processed with gettext_quoted it doesn't appear to be
> translated anywhere (or at least I couldn't find where).

I'm not sure about unstable, but at least the version of GRUB in
experimental has translations of messages in util/grub.d/.

> === modified file 'util/grub.d/20_linux_xen.in'
> --- util/grub.d/20_linux_xen.in       2010-12-21 12:49:29 +0000
> +++ util/grub.d/20_linux_xen.in       2010-12-23 09:14:38 +0000
> @@ -60,11 +60,11 @@
>    args="$5"
>    xen_args="$6"
>    if ${recovery} ; then
> -    title="$(gettext_quoted "%s, with Linux %s and XEN %s (recovery mode)")"
> +    title="$(gettext_quoted "%s, with Xen %s and Linux %s (recovery mode)")"
>    else
> -    title="$(gettext_quoted "%s, with Linux %s and XEN %s")"
> +    title="$(gettext_quoted "%s, with Xen %s and Linux %s")"
>    fi
> -  printf "menuentry '${title}' ${CLASS} {\n" "${os}" "${version}" 
> "${xen_version}"
> +  printf "menuentry '${title}' ${CLASS} {\n" "${os}" "${xen_version}" 
> "${version}"
>    if ! ${recovery} ; then
>        save_default_entry | sed -e "s/^/\t/"
>    fi

Thanks,

-- 
Colin Watson                                       address@hidden