[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] Add grub_efi_get_variable
|
From: |
Matthew Garrett |
|
Subject: |
Re: [PATCH 2/4] Add grub_efi_get_variable |
|
Date: |
Wed, 8 Feb 2012 20:19:11 +0000 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Feb 08, 2012 at 09:09:23PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 08.02.2012 21:04, Matthew Garrett wrote:
> >On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder'
> >Serbinenko wrote:
> >>>+ for (i=0; i<(int)grub_strlen((char *)var); i++)
> >>>+ var16[i] = var[i];
> >>>+ var16[i] = '\0';
> >>>+
> >>We use grub_utf8_to_utf16. Also don't forget to multiply the malloc
> >>length by GRUB_MAX_UTF16_PER_UTF8 ((GRUB_MAX_UTF16_PER_UTF8 * length
> >>+ 1) * sizeof (var16[0]))
> >That's not currently exported. Any problem with changing that?
> It already is. The prototype and the define is in grub/charset.h
Oh, I was thinking of modules, but then this is already in core. Yes,
I'll do that.
--
Matthew Garrett | address@hidden
[PATCH 4/4] Add support for getting EDID via EFI, Matthew Garrett, 2012/02/08
[PATCH 3/4] Prefer GOP devices which implement the pci_io protocol, Matthew Garrett, 2012/02/08
[PATCH 1/4] Add PCI protocols, Matthew Garrett, 2012/02/08
Re: Some improvements to EFI GOP support, Keshav P R, 2012/02/08