Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 20.04.2012 13:40, Michael Chang wrote:
> This patch fixes grub-probe fails on probing devices under
> /dev/disk/by-id and other similar mount-by alias names. The method
> used to determine the whole disk is by it's name without numeric
> character end, but this may be wrong for the by-(id|uuid|path) names
> as they are not necessary ended without numeric character. For
> instance, my disk was named
> "/dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761".
>
> The fix is use resolved link to kernel device names (like /dev/sda)
> instead of these alias names.
>
> Downstream bug:
> https://bugzilla.novell.com/show_bug.cgi?id=757746
This patch isn't correct. One of the problems is the use of PATH_MAX
instead of our own realpath wrapper. Another, more serious one is that
realpath would transform a symlink to any of /dev/mapper/* to dm-X which
isn't really usable. Instead we should find out how the untransformed
name landed into this part.
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature