grub-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] Fix grub-probe with userland partition support

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH,HURD] Fix grub-probe with userland partition support
Date: Tue, 24 Apr 2012 10:55:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 
On 24.04.2012 01:34, Samuel Thibault wrote:
> +       if (errno == ENOENT && part >= 5)
> +         {
This introduces an assumption that if part >=5 is missing then there are
no additional partitions. While this is true for msdos, it's false for
GPT, where such config is common after deleting a partition. Moreover,
APM (apple) partitions often start at 8.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]