[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] change misleading comment about device.map in grub-install
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] change misleading comment about device.map in grub-install |
Date: |
Sun, 27 Jan 2013 16:18:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 |
Comitted, thanks.
On 22.01.2013 18:01, Andrey Borzenkov wrote:
> grub-install is not supposed to create device.map; change comment
> to avoid confusion. It was already considered a bug by users.
>
> Signed-off-by: Andrey Borzenkov <address@hidden>
>
> ---
> ChangeLog | 5 +++++
> util/grub-install.in | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 8c4d087..61dda4e 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-01-22 Andrey Borzenkov <address@hidden>
> +
> + * util/grub-install.in: change misleading comment about
> + device.map creation
> +
> 2013-01-22 Colin Watson <address@hidden>
>
> * util/grub-reboot.in (usage): Document the need for
> diff --git a/util/grub-install.in b/util/grub-install.in
> index aac27c7..9e63cf5 100644
> --- a/util/grub-install.in
> +++ b/util/grub-install.in
> @@ -505,7 +505,7 @@ if test $recheck = yes; then
> rm -f "$device_map"
> fi
>
> -# Create the device map file if it is not present.
> +# Device map file is optional
> if test -f "$device_map"; then
> # Make sure that there is no duplicated entry.
> tmp=`sed -n '/^([fh]d[0-9]*)/s/\(^(.*)\).*/\1/p' "$device_map" \
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature