[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [3/4] [PATCH] start angle (option of circular_progress) is measured
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities |
Date: |
Tue, 19 Mar 2013 08:01:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 |
On 15.03.2013 18:56, Lennart Sorensen wrote:
> On Fri, Mar 15, 2013 at 08:52:08PM +0400, Andrey Borzenkov wrote:
>> В Wed, 13 Mar 2013 14:52:13 +0400
>> Vladimir Testov <address@hidden> пишет:
>>
>>> In current state, start angle is measured in "parrots", where 1 "parrot" =
>>> 1 /
>>> 256 of full circle.
>>>
>>> With simple patch we can set start angle in degrees (which makes no
>>> difference
>>> for the program, but makes configuration to be more user-friendly)
>>>
>>
>> This has compatibility issue and probably cannot be done without
>> introducing theme file format version.
>>
>> What about adding new parameter name instead (although start_angle_angle
>> looks rather silly)?
>
> start_angle_degrees?
>
> Could have start_angle_radians too (although it would need floating
> point to be useful).
GRUB doesn't use floats at all as it would decrease compatibility and
brings nothing useful to us.
>
> Could even have start_angle_gradians
>
This would be featuritus
signature.asc
Description: OpenPGP digital signature