|
From: | Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: | Re: [PATCH] enable emuusb and emupci on emu platform only |
Date: | Thu, 25 Jul 2013 16:44:08 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 |
On 21.07.2013 08:53, Andrey Borzenkov wrote:
I think it's better to reset COND_EMU_PCI/COND_EMU_USB to false in configure state when not compiling for emu as usage of both enable and consition simultaneously is marginal and it's beter not to rely on it (so to i.a. permit its removal if necessary)Is there any reason we may want to build them when not building --with-platform=emu?
Signed-off-by: Andrey Borzenkov <address@hidden> --- grub-core/Makefile.core.def | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 06617d7..230bed5 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -477,6 +477,7 @@ module = { module = { name = emuusb; common = bus/usb/usb.c; + enable = emu; condition = COND_GRUB_EMU_USB; }; @@ -546,6 +547,7 @@ module = { common = bus/emu/pci.c; common = commands/lspci.c; + enable = emu; condition = COND_GRUB_EMU_PCI; };
[Prev in Thread] | Current Thread | [Next in Thread] |