[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) |
Date: |
Sat, 16 Nov 2013 16:31:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 |
On 16.11.2013 16:23, Leif Lindholm wrote:
> On Sat, Nov 16, 2013 at 04:19:48PM +0100, Vladimir 'φ-coder/phcoder'
> Serbinenko wrote:
>>>> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall)
>>>> mov lr, pc
>>>> ldr pc, grub_uboot_syscall_ptr
>>>> str r8, gd_backup
>>>> + str r9, gd_backup + 4
>>>>
>>>> ldr r8, transition_space
>>>> ldr lr, transition_space + 4
>>>>
>>>> Can I push this fix too?
>>>
>>> Umm, at second thought - the gd pointer(s) wouldn't be changing.
>>> So the correct fix would rather be to
>>> - str r8, gd_backup
>>> ?
>>>
>> Was this tested?
>
> Tested on Ian's qemu, with an "mmc" block device..
>
Go ahead.
> /
> Leif
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), (continued)
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Leif Lindholm, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Andrey Borzenkov, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Leif Lindholm, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Leif Lindholm, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Leif Lindholm, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Vladimir 'φ-coder/phcoder' Serbinenko, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm), Leif Lindholm, 2013/11/16
- Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm),
Vladimir 'φ-coder/phcoder' Serbinenko <=
Re: [PATCH] [ARM] Enable boot module for arm, Andrey Borzenkov, 2013/11/16