[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] add grub_qsort_strcmp to use when sorting array of strings
|
From: |
Andrey Borzenkov |
|
Subject: |
Re: [PATCH] add grub_qsort_strcmp to use when sorting array of strings |
|
Date: |
Sat, 30 Nov 2013 14:59:59 +0400 |
В Sat, 30 Nov 2013 11:39:12 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> On 29.11.2013 18:01, Andrey Borzenkov wrote:
> > Compare function used in qsort gets arguments by reference, so strcmp
> > cannot be used directly - it expects pointer to char, but gets pointer
> > to pointer to char.
> >
> > Introduce new helper grub_qsort_strcmp and use it in grub-install.
> > This helper is going to be used in a couple more places as well so
> > add it to global file, not in grub-install.c.
> >
> Nice catch. But I don't we have enough use for grub_qsort_strcmp to make
> it global. Can you make it static in grub-install.c ?
I have pending patches to sort long lists in help output of commands
(grub-mkimage and grub-probe target lists). They are long enough to
wish some ordering.
signature.asc
Description: PGP signature