Re: [PATCH 2/2] second attempt to fix using grub device name as install

grub-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] second attempt to fix using grub device name as install

From:	Vladimir 'φ-coder/phcoder' Serbinenko
Subject:	Re: [PATCH 2/2] second attempt to fix using grub device name as install device
Date:	Sat, 07 Dec 2013 09:47:44 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9

On 07.12.2013 09:44, Andrey Borzenkov wrote:
> +       install_device[grub_strlen (install_device) - 1] = '\0';
> +       install_drive = xstrdup (install_device + 1);
> +       install_device[grub_strlen (install_device) - 1] = ')';
> +        }
Bad code. You forgot that grub_strlen changes with your operations. You
need to keep explicit pointer.

signature.asc
Description: OpenPGP digital signature

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH] Fix grub-install with OS device name, Colin Watson, 2013/12/04
- Re: [PATCH] Fix grub-install with OS device name, Jonathan McCune, 2013/12/04
  - Re: [PATCH] Fix grub-install with OS device name, Colin Watson, 2013/12/04
    - Re: [PATCH] Fix grub-install with OS device name, arvidjaar, 2013/12/05
    - Re: [PATCH] Fix grub-install with OS device name, Andrey Borzenkov, 2013/12/05
    - [PATCH 1/2] revert 69ca97c820, it broke using OS device name as install device, Andrey Borzenkov, 2013/12/07
    - [PATCH 2/2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
    - Re: [PATCH 2/2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko <=
    - Re: [PATCH 2/2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
    - Re: [PATCH 2/2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07
    - [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
    - Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07
    - Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Andrey Borzenkov, 2013/12/07
    - Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/12/07

Prev by Date: [PATCH 2/2] second attempt to fix using grub device name as install device
Next by Date: Re: [PATCH 2/2] second attempt to fix using grub device name as install device
Previous by thread: [PATCH 2/2] second attempt to fix using grub device name as install device
Next by thread: Re: [PATCH 2/2] second attempt to fix using grub device name as install device
Index(es):
- Date
- Thread