Re: zfs pool devices detection in core/osdep/unix/getroot.c

[Toomas Soome]

> 
> Could you please send git format-patch (or git send-email) ready to
> apply? As far as I know policy, patches on behalf of others are rather
> frowned upon.
> 

will do. however, I just realised, this one needs to be delayed till actual zfs 
update is passed and accepted, which probably will take some time due to size… 



>> -  for (i = 0; i < nvlist_count; i++)
>> -    {
>> -      if (nvlist_lookup_string (children[i], "path", &device) != 0)
>> +  if (nvlist_lookup_nvlist_array (vdev_tree, "children", &children, 
>> &nvlist_count) != 0){
> 
> curly braces style
> 

updated.
>> 
>> +  } else {
> 
> curly braces style
> 

updated.

>> +    for (i = 0; i < nvlist_count; i++)
>> +      {
>> +        grub_util_find_child_vdevs(children[i], devices, ndevices, 
>> devices_allocated);
>> +      }
>> +  }
> 
> all braces in this branch are reundant.

removed inner ones, however, I think outer ones, even as strictly not needed, 
might still help readability.

rgds,
toomas