Re: [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings.

[Toomas Soome]

> On 15.04.2015, at 8:16, Andrei Borzenkov <address@hidden> wrote:
> 
> В Mon, 13 Apr 2015 20:32:53 +0300
> Toomas Soome <address@hidden> пишет:
> 
>> hi!
>> 
>> just checked the  git://git.gnupg.org/libgcrypt.git - apparently it has been 
>> changed compared to one included in grub; the int i versus unsigned keylen 
>> is still there (visual inspection), the { }  were inserted to if (0) ; 
>> statement. 
>> 
>> so second half is already fixed.  I did report the signed/unsigned compare 
>> issue to gcrypt-devel, but then the question is about updating libcgrypt in 
>> grub; 
> 
> It gets updated every now and then. "Upstream first" makes sure that if
> we add local patch it won't be lost next time library is pulled in.
> 
> Just to be sure - these are just warnings, right? They do not cause
> build failure or any regression?


they are just warnings, yes, and *can* cause problems if the -Werror is used. 
which is the case in some build environments.

anyhow, as I wrote, I did report signed vs unsigned issue to upstream, I 
haven’t seen any responses yet.

rgds,
toomas