Re: multiboot2.h & multiboot_header_tag_module_align

[Andrei Borzenkov]

В Thu, 04 Jun 2015 19:29:17 +0300
Toomas Soome <address@hidden> пишет:

> 
> > On 04.06.2015, at 19:19, Andrei Borzenkov <address@hidden> wrote:
> > 
> > В Thu, 04 Jun 2015 19:04:46 +0300
> > Toomas Soome <address@hidden> пишет:
> > 
> >> 
> >>> On 04.06.2015, at 18:31, Vladimir 'φ-coder/phcoder' Serbinenko 
> >>> <address@hidden> wrote:
> >>> 
> >>> On 04.06.2015 14:18, Toomas Soome wrote:
> >>>> hi!
> >>>> 
> >>>> i know this tag (multiboot_header_tag_module_align) is not really used, 
> >>>> but it still would be nice if the copy/paste error of the actual 
> >>>> structure would be fixed;)
> >>>> 
> >>> Can you propose a patch?
> >>>> rgds,
> >> 
> >> as its header tag, i think following should be it; header tags have 16bit 
> >> ints for type and flags, 32bit size and based on name, this tag is to 
> >> request bootloader to use specified alignment, so the data field should be 
> >> 32bit uint as well (default MULTIBOOT_MOD_ALIGN is 0x00001000).
> >> 
> >> diff --git a/include/multiboot2.h b/include/multiboot2.h
> >> index 3ccff15..e3064da 100644
> >> --- a/include/multiboot2.h
> >> +++ b/include/multiboot2.h
> >> @@ -156,9 +156,7 @@ struct multiboot_header_tag_module_align
> >>   multiboot_uint16_t type;
> >>   multiboot_uint16_t flags;
> >>   multiboot_uint32_t size;
> >> -  multiboot_uint32_t width;
> >> -  multiboot_uint32_t height;
> >> -  multiboot_uint32_t depth;
> >> +  multiboot_uint32_t align;
> > What about consulting multiboot2 specification? :)
> 
> 
> oh right, for some reason i missed the actual specification and was stumbling 
> on link to this broken header;)
> 
> this is of course the correct one 
> (http://nongnu.askapache.com/grub/phcoder/multiboot.pdf 3.1.9 If this tag is 
> present modules must be page aligned):
> 
> diff --git a/include/multiboot2.h b/include/multiboot2.h
> index 3ccff15..9d48627 100644
> --- a/include/multiboot2.h
> +++ b/include/multiboot2.h
> @@ -156,9 +156,6 @@ struct multiboot_header_tag_module_align
>    multiboot_uint16_t type;
>    multiboot_uint16_t flags;
>    multiboot_uint32_t size;
> -  multiboot_uint32_t width;
> -  multiboot_uint32_t height;
> -  multiboot_uint32_t depth;
>  };
>  
>  struct multiboot_color
> 

Could you make properly formatted git patch either as attachment or as
git send-email?