Re: [PATCH] net: don't free uninitialized sockets in dns

[Andrei Borzenkov]

18.08.2015 21:03, Josef Bacik пишет:
> If we cannot open a connection to our dns server we will have NULL sockets in
> our array, so don't do the cleanup on any sockets that didn't get created.

We can avoid having holes to start with. Could you test attached patch?

> Signed-off-by: Josef Bacik <address@hidden>
> ---
>   grub-core/net/dns.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/net/dns.c b/grub-core/net/dns.c
> index 9d0c8fc..c356318 100644
> --- a/grub-core/net/dns.c
> +++ b/grub-core/net/dns.c
> @@ -601,7 +601,10 @@ grub_net_dns_lookup (const char *name,
>     grub_free (data.name);
>     grub_netbuff_free (nb);
>     for (j = 0; j < send_servers; j++)
> -    grub_net_udp_close (sockets[j]);
> +    {
> +      if (sockets[j])
> +       grub_net_udp_close (sockets[j]);
> +    }
>
>     grub_free (sockets);

dns-null-free.patch
Description: Text Data