Re: [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5).

[Peter Jones]

On Sat, Oct 10, 2015 at 09:48:58PM +0300, Andrei Borzenkov wrote:
> 26.02.2014 02:12, Peter Jones пишет:
> >This is version 4.
> >
> >Changes from version 1:
> >- handles SHIFT as a modifier
> >- handles F11 and F12 keys
> >- uses the handle provided by the system table to find our _EX protocol.
> >
> >Changes from version 2:
> >- eliminate duplicate keycode translation.
> >
> >Changes from version 3:
> >- Do not add the shift modifier for any ascii character between space
> >   (0x20) and DEL (0x7f); the combination of the modifier and many of the
> >   keys causes it not to be recognized at all.  Specifically, if we
> >   include the modifier on any querty punctuation character, i.e.
> >   anything the string "address@hidden&*()_+{}|:\"<>?" represents in C, it 
> > stops
> >   being recognized whatsoever.
> >
> >Changes from version 4:
> >- Always initialize term->data from locate protocol (i.e. make it
> >   unconditional.)
> >
> 
> Are there open issues with this patch? Is it used by Fedora? The part about
> SHIFT state bothers me, what happens for non-ASCII printable characters?
> UEFI spec is extremely vague here.
> 
> As currently there is no way to actually input Ctrl-X or similar this is
> needed. It may also allow us to actually implement keystatus on EFI.

Fedora is using it, and has been for 18 months or so.  As far as I know,
there aren't any known issues.

-- 
        Peter