[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] FAT/exFAT: Fix wrong size detection for files > 4GB
|
From: |
Carlo Caione |
|
Subject: |
Re: [PATCH] FAT/exFAT: Fix wrong size detection for files > 4GB |
|
Date: |
Wed, 24 Aug 2016 18:12:53 +0200 |
On Wed, Aug 24, 2016 at 6:08 PM, Vladimir 'phcoder' Serbinenko
<address@hidden> wrote:
> This makes it unsigned from signed. Did you check that no code relies on
> signedness in fat.c?
AFAICT there is no use for the signedness in fat.c
Also, if it were the case this code would be broken in fat.c
data->file_size = ctxt.dir.file_size
since ctxt.dir.file_size is grub_uint64_t for MODE_EXFAT and
grub_uint32_t for !MODE_EXFAT
--
Carlo Caione | +39.340.80.30.096 | Endless