Re: [PATCH] Make grub-install check for errors from efibootmgr

[Daniel Kiper]

On Wed, Feb 14, 2018 at 03:30:48PM +0000, Steve McIntyre wrote:
> Apologies for the delayed response - just found this in the archives
> but for some reason I never got it in my inbox. Weird... :-/
>
> On Tue, Feb 06, 2018 at 04:29:23PM +0100, Daniel Kiper wrote:
> >On Wed, Jan 31, 2018 at 09:49:36PM +0000, Steve McIntyre wrote:
> >> Code is currently ignoring errors from efibootmgr, giving users
> >> clearly bogus output like:
> >>
> >>         Setting up grub-efi-amd64 (2.02~beta3-4) ...
> >>         Installing for x86_64-efi platform.
> >>         Could not delete variable: No space left on device
> >>         Could not prepare Boot variable: No space left on device
> >>         Installation finished. No error reported.
> >>
> >> and then potentially unbootable systems. If efibootmgr fails,
> >> grub-install should know that and report it!
> >>
> >> We've been using this patch in Debian now for some time, with no ill
> >
> >s/this/similar/? If you are OK I will change that during commit.
>
> Yup, perfect. :-)
>
> >If there are no objections I will commit this in a week or so.
>
> Please...

Applied!

> --
> Steve McIntyre, Cambridge, UK.                                address@hidden
> We don't need no education.
> We don't need no thought control.

Ha! :-)))

Daniel