Re: [PATCH 3/7] cryptomount luks allow multiple passphrase attempts

[TJ]

On 14/03/18 09:45, John Lane wrote:
> --- a/grub-core/disk/luks.c
> +++ b/grub-core/disk/luks.c
> @@ -321,10 +321,10 @@ configure_ciphers (grub_disk_t disk, const char 
> *check_uuid,
>  
>  static grub_err_t
>  luks_recover_key (grub_disk_t source,
> -               grub_cryptodisk_t dev,
> -               grub_file_t hdr,
> -               grub_uint8_t *keyfile_bytes,
> -               grub_size_t keyfile_bytes_size)
> +                  grub_cryptodisk_t dev,
> +                  grub_file_t hdr,
> +                  grub_uint8_t *keyfile_bytes,
> +                  grub_size_t keyfile_bytes_size)

---8-<--- snip

Much of this patch is moving existing code around, could it be
refactored to avoid that so as to make the new code stand out?