[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] Add helper to check the btrfs header.
From: |
Goffredo Baroncelli |
Subject: |
[PATCH 2/7] Add helper to check the btrfs header. |
Date: |
Tue, 24 Apr 2018 21:13:11 +0200 |
This helper was used in few places to help the debugging. As conservative
approach, in case of error it is only logged.
Signed-off-by: Goffredo Baroncelli <address@hidden>
---
grub-core/fs/btrfs.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c
index b0032ea46..01a1fc7a1 100644
--- a/grub-core/fs/btrfs.c
+++ b/grub-core/fs/btrfs.c
@@ -77,7 +77,8 @@ struct btrfs_header
{
grub_btrfs_checksum_t checksum;
grub_btrfs_uuid_t uuid;
- grub_uint8_t dummy[0x30];
+ grub_uint64_t bytenr;
+ grub_uint8_t dummy[0x28];
grub_uint32_t nitems;
grub_uint8_t level;
} GRUB_PACKED;
@@ -286,6 +287,23 @@ free_iterator (struct grub_btrfs_leaf_descriptor *desc)
grub_free (desc->data);
}
+static grub_err_t
+check_btrfs_header (struct grub_btrfs_data *data, struct btrfs_header *header,
+ grub_disk_addr_t addr)
+{
+ if (grub_le_to_cpu64 (header->bytenr) != addr)
+ {
+ grub_dprintf ("btrfs", "btrfs_header.bytenr is not addr\n");
+ return grub_error (GRUB_ERR_BAD_FS, "header bytenr is not addr");
+ }
+ if (grub_memcmp (data->sblock.uuid, header->uuid, sizeof(grub_btrfs_uuid_t)))
+ {
+ grub_dprintf ("btrfs", "btrfs_header.uuid doesn't match\n");
+ return grub_error (GRUB_ERR_BAD_FS, "header uuid doesn't match");
+ }
+ return GRUB_ERR_NONE;
+}
+
static grub_err_t
save_ref (struct grub_btrfs_leaf_descriptor *desc,
grub_disk_addr_t addr, unsigned i, unsigned m, int l)
@@ -341,6 +359,7 @@ next (struct grub_btrfs_data *data,
err = grub_btrfs_read_logical (data, grub_le_to_cpu64 (node.addr),
&head, sizeof (head), 0);
+ check_btrfs_header (data, &head, grub_le_to_cpu64 (node.addr));
if (err)
return -err;
@@ -402,6 +421,7 @@ lower_bound (struct grub_btrfs_data *data,
/* FIXME: preread few nodes into buffer. */
err = grub_btrfs_read_logical (data, addr, &head, sizeof (head),
recursion_depth + 1);
+ check_btrfs_header (data, &head, addr);
if (err)
return err;
addr += sizeof (head);
--
2.17.0
- [PATCH V2] Add support for BTRFS raid5/6 to GRUB, Goffredo Baroncelli, 2018/04/24
- [PATCH 1/7] Add support for reading a filesystem with a raid5 or raid6 profile., Goffredo Baroncelli, 2018/04/24
- [PATCH 2/7] Add helper to check the btrfs header.,
Goffredo Baroncelli <=
- [PATCH 3/7] Move from the find_device the error logging logic to the callee., Goffredo Baroncelli, 2018/04/24
- [PATCH 4/7] Avoiding scanning for an already not found device., Goffredo Baroncelli, 2018/04/24
- [PATCH 5/7] Refactor the code of read from disk, Goffredo Baroncelli, 2018/04/24
- [PATCH 6/7] Add support for recovery for a raid5 btrfs profiles., Goffredo Baroncelli, 2018/04/24
- [PATCH 7/7] Add raid6 recovery., Goffredo Baroncelli, 2018/04/24