[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] ofnet: Initialize structs in bootpath parser
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v2] ofnet: Initialize structs in bootpath parser |
|
Date: |
Tue, 4 Sep 2018 12:27:57 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Mon, Sep 03, 2018 at 10:09:15AM +0200, Julian Andres Klode wrote:
> Code later on checks if variables inside the struct are
> 0 to see if they have been set, like if there were addresses
> in the bootpath.
>
> The variables were not initialized however, so the check
> might succeed with uninitialized data, and a new interface
> with random addresses and the same name is added. This causes
> $net_default_mac to point to the random one, so, for example,
> using that variable to load per-mac config files fails.
>
> Bug-Ubuntu: https://bugs.launchpad.net/bugs/1785859
> Signed-off-by: Julian Andres Klode <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
Daniel