Re: [PATCH v2 2/2] btrfs: Add zstd support to grub btrfs

[Nick Terrell]

> On Oct 9, 2018, at 12:07 PM, Daniel Kiper <address@hidden> wrote:
> On Mon, Oct 08, 2018 at 04:06:21PM -0700, Nick Terrell wrote:
>> Adds zstd support to the btrfs module. I'm not sure that my changes to the
>> Makefiles are correct, please let me know if I need to do something
>> differently.
>> 
>> Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd
>> compression. A test case was also added to the test suite that fails before
>> the patch, and passes after.
>> 
>> Signed-off-by: Nick Terrell <address@hidden>
>> ---
>> v1 -> v2:
>> - Fix comments from Daniel Kiper
>> 
>> Makefile.util.def            |  10 +++-
>> grub-core/Makefile.core.def  |  10 +++-
>> grub-core/fs/btrfs.c         | 105 ++++++++++++++++++++++++++++++++++-
>> grub-core/lib/zstd/up        |   1 -
> 
> Please do not take this file into patch #1.

Oops, sorry about that.

>> 
>> 
>> +static void* grub_zstd_malloc (void* state, size_t size)
>> +{
>> +    (void)state;
> 
> Do we need that?

Yeah, otherwise my compiler (gcc-7.3) gives an unused parameter error.

Thanks for the fast review! I'll have an updated version up later today.

Nick