[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs
From: |
Nick Terrell |
Subject: |
Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs |
Date: |
Thu, 11 Oct 2018 18:56:35 +0000 |
> On Oct 11, 2018, at 11:15 AM, Daniel Kiper <address@hidden> wrote:
>
> Hi Nick,
>
> CC-ing Goffredo.
>
> On Tue, Oct 09, 2018 at 04:21:35PM -0700, Nick Terrell wrote:
>> Hi all,
>>
>> This patch set imports the upstream zstd library, adds zstd support to the
>> btrfs module, and adds a test case. I've also tested the patch set by storing
>> my boot partition in btrfs with and without zstd compression and rebooting.
>>
>> The fist patch imports the files needed to support zstd decompression from
>> zstd-1.3.6 as-is. It is a very large patch. In case it doesn't make it,
>> I've included the commit hash and the script I used to download the files.
>>
>> Upstream zstd commit hash: 4fa456d7f12f8b27bd3b2f5dfd4f46898cb31c24
>> Upstream zstd commit name: Merge pull request #1354 from facebook/dev
>
> In general I am happy with the patches. If everything is done what
> I have asked for then I will get them. However, there is one problem.
> Another big btrfs (RAID) patchset is lurking around for months. It is
> almost ready. Goffredo, I am looking at you... So, I would like to take
> RAID patchset first. If it is in the tree then I will ask you to rebase
> zstd patchset on top of RAID patchset and I will take it. Nick, are you
> OK with that?
That works for me, thanks!
> Daniel
- [PATCH v3 2/2] btrfs: Add zstd support to grub btrfs, (continued)