Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

[Nick Terrell]

> On Oct 22, 2018, at 4:02 AM, Daniel Kiper <address@hidden> wrote:
> 
> On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote:
>> 
>> Hi All,
>> 
>> the aim of this patches set is to provide support for a BTRFS raid5/6
>> filesystem in GRUB.
>> 
>> The first patch, implements the basic support for raid5/6. I.e this works 
>> when
>> all the disks are present.
>> 
>> The next 5 patches, are preparatory ones.
>> 
>> The 7th patch implements the raid5 recovery for btrfs (i.e. handling the
>> disappearing of 1 disk).
>> The 8th patch makes the code for handling the raid6 recovery more generic.
>> The last one implements the raid6 recovery for btrfs (i.e. handling the
>> disappearing up to two disks).
>> 
>> I tested the code in grub-emu, and it works both with all the disks,
>> and with some disks missing. I checked the crc32 calculated from grub and
>> from linux and these matched. Finally I checked if the support for md raid6
>> still works properly, and it does (with all drives and with up to 2 drives
>> missing)
>> 
>> Comments are welcome.
> 
> In general whole patch series LGTM. +/- some nit picks including changes
> for patch #7. If you are OK with them and there are no objections then
> I will apply the patches in a week or so.

Awesome! I'll look for the update and send an rebased version of the zstd
patch set when it is out.

-Nick