Re: [PATCH v2 09/10] RISC-V: Add to build system

[Bin Meng]

Hi Alex,

On Wed, Nov 14, 2018 at 9:11 PM Alexander Graf <address@hidden> wrote:
>
> This patch adds support for RISC-V to the grub build system. With this
> patch, I can successfully build grub on RISC-V as a UEFI application.
>
> Signed-off-by: Alexander Graf <address@hidden>
> Reviewed-by: Alistair Francis <address@hidden>
> ---
>  configure.ac                 | 28 ++++++++++++++++++++++++++--
>  gentpl.py                    |  9 ++++++---
>  grub-core/Makefile.am        | 12 ++++++++++++
>  grub-core/Makefile.core.def  | 29 +++++++++++++++++++++++++++++
>  grub-core/commands/file.c    | 14 +++++++++++++-
>  grub-core/kern/compiler-rt.c |  3 ++-
>  grub-core/kern/efi/mm.c      |  2 +-
>  grub-core/kern/emu/cache.c   |  6 ++++++
>  grub-core/kern/emu/cache_s.S |  1 +
>  grub-core/kern/emu/lite.c    |  2 ++
>  grub-core/lib/efi/halt.c     |  3 ++-
>  grub-core/lib/setjmp.S       |  2 ++
>  include/grub/compiler-rt.h   |  6 ++++--
>  include/grub/efi/api.h       |  3 ++-
>  include/grub/efi/efi.h       |  2 +-
>  include/grub/util/install.h  |  2 ++
>  util/grub-install-common.c   |  2 ++
>  util/grub-install.c          | 28 ++++++++++++++++++++++++++++
>  util/grub-mknetdir.c         |  4 +++-
>  util/grub-mkrescue.c         | 16 +++++++++++++++-
>  util/mkimage.c               | 32 ++++++++++++++++++++++++++++++++
>  21 files changed, 191 insertions(+), 15 deletions(-)
>

This patch currently does not handle the following configuration:

- use riscv32-* toolchain to build riscv64 target (-m64 required)
- use riscv64-* toolchain to build riscv32 target (-m32 required)

Can you please add the missing bits in configure.ac?

Regards,
Bin