[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] uboot: Add the missing disk write operation support
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v2] uboot: Add the missing disk write operation support |
|
Date: |
Tue, 22 Jan 2019 18:39:40 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Jan 22, 2019 at 12:02:10PM +0200, Cristian Ciocaltea wrote:
> uboot_disk_write() is currently lacking the write support
> to storage devices because, historically, those devices did not
> implement block_write() in U-Boot.
>
> The solution has been tested using a patched U-Boot loading
> and booting GRUB in a QEMU vexpress-a9 environment.
> The disk write operations were triggered with GRUB's save_env
> command.
>
> Signed-off-by: Cristian Ciocaltea <address@hidden>
> Reviewed-by: Daniel Kiper <address@hidden>
> ---
>
> Changes since v1:
> * Fix compiler error when building with '-Werror=discarded-qualifiers':
> passing argument 2 of 'grub_uboot_dev_write' discards 'const'
> qualifier from pointer target type
Pushed. Thanks!
Daniel