[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/3] mkimage: Clarify file alignment in efi case
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v5 3/3] mkimage: Clarify file alignment in efi case |
|
Date: |
Mon, 28 Jan 2019 13:27:07 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Jan 25, 2019 at 12:45:16PM +0100, Alexander Graf wrote:
> There are a few spots in the PE generation code for EFI binaries that uses
> the section alignment rather than file alignment, even though the alignment
> is really only file bound.
>
> Replace those cases with the file alignment constant instead.
>
> Reported-by: Daniel Kiper <address@hidden>
> Signed-off-by: Alexander Graf <address@hidden>
Great! However, this patch misses changes for EFI32_HEADER_SIZE
and EFI64_HEADER_SIZE macros. In general I think about
s/GRUB_PE32_SECTION_ALIGNMENT/GRUB_PE32_FILE_ALIGNMENT/
I have asked about that in my earlier emails too...
Daniel