Re: [PATCHv2][ 3/6] cryptodisk: enable the backends to implement detached headers

[Patrick Steinhardt]

On Tue, Mar 17, 2020 at 08:57:37AM +0100, Denis 'GNUtoo' Carikli wrote:
> From: John Lane <address@hidden>
> @@ -242,7 +243,8 @@ grub_util_get_geli_uuid (const char *dev)
>  #endif
>  
>  static grub_cryptodisk_t
> -geli_scan (grub_disk_t disk, const char *check_uuid, int boot_only)
> +geli_scan (grub_disk_t disk, const char *check_uuid, int boot_only,
> +        grub_file_t hdr __attribute__((__unused__)))
>  {
>    grub_cryptodisk_t newdev;
>    struct grub_geli_phdr header;

Hmm. So in case any of the backends gets a non-NULL `hdr` that it can't
support, shouldn't we return an error? Otherwise the backend might do
something the user didn't intend to do when using `cryptomount -H` e.g.
for LUKS2 or Geli.

Patrick

signature.asc
Description: PGP signature