Re: [PATCH v4 04/15] types: Define GRUB_CHAR_BIT based on compiler macro instead of using literal.

[Daniel Kiper]

On Sun, Nov 15, 2020 at 10:42:39AM +0100, Patrick Steinhardt wrote:
> On Fri, Nov 06, 2020 at 10:44:24PM -0600, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  include/grub/types.h | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/grub/types.h b/include/grub/types.h
> > index 035a4b528..495c86bb1 100644
> > --- a/include/grub/types.h
> > +++ b/include/grub/types.h
> > @@ -72,6 +72,14 @@
> >  # endif
> >  #endif
> >
> > +#ifndef __CHAR_BIT__
> > +#error __CHAR_BIT__ is not defined
> > +#elif __CHAR_BIT__ != 8
> > +#error __CHAR_BIT__ is not equal 8
> > +#else
> > +#define GRUB_CHAR_BIT __CHAR_BIT__
> > +#endif
> > +
>
> Nested defines typically use spaces:

Yeah, good point. Anyway, I will fix it before commiting.

> #ifndef __CHAR_BIT__
> # error __CHAR_BIT__ is not defined
> #elif __CHAR_BIT__ != 8
> # error __CHAR_BIT__ is not equal 8
> #else
> # define GRUB_CHAR_BIT __CHAR_BIT__
> #endif

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel