Re: [PATCH v8 00/18] Cryptodisk fixes for v2.06 redux

[Patrick Steinhardt]

On Thu, Dec 10, 2020 at 05:20:59PM +0100, Daniel Kiper wrote:
> On Tue, Dec 08, 2020 at 04:45:31PM -0600, Glenn Washburn wrote:
> > This patch series, fixes issues with v7 series. Some of those patches had
> > changes applied to the wrong patch. The added structure member was renamed
> > again, this time to idx. And there is an added patch that renames some json
> > index variables to note that they are such.
> >
> > Glenn
> >
> > Glenn Washburn (18):
> >   disk: Rename grub_disk_get_size to grub_disk_native_sectors
> >   misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments
> >   whitespace: convert 8 spaces to tabs
> >   luks2: Remove unused argument in grub_error
> >   luks2: Make sure all fields of output argument in luks2_parse_digest()
> >     are written to
> >   luks2: Add idx member to struct grub_luks2_keyslot/segment/digest
> >   luks2: Use more intuitive object name instead of json index in user
> >     messages
> >   luks2: Rename json index variables to names that they are obviously
> >     json indexes
> >   luks2: Add string "index" to user strings using a json index.
> >   cryptodisk: Add macro GRUB_TYPE_BITS() to replace some literals
> >   cryptodisk: Add macros GRUB_TYPE_U_MAX/MIN(type) to replace literals
> >   luks2: grub_cryptodisk_t->total_sectors is the max number of device
> >     native sectors
> >   cryptodisk: Properly handle non-512 byte sized sectors
> >   luks2: Better error handling when setting up the cryptodisk
> >   luks2: Error check segment.sector_size
> >   mips: Enable __clzdi2()
> >   misc: Add grub_log2ull macro for calculating log base 2 of 64-bit
> >     integers
> >   luks2: Use grub_log2ull to calculate log_sector_size and improve
> >     readability
> 
> I will get all the patches except #14 and maybe some changes after that
> one which does not apply due to lack of it.
> 
> Thank you for doing the work!
> 
> Daniel

For what it's worth, I've also gone through all patches except 14 and
added by RBs. Thanks!

Patrick

signature.asc
Description: PGP signature