Re: [PATCH 1/2] Add bigtime support for xfs driver

[Javier Martinez Canillas]

Hello Carlos,

Please add a "fs/xfs:" prefix to your subject line.

On 3/23/21 2:29 PM, Carlos Maiolino wrote:
> XFS filesystem now supports bigtime feature, to overcome y2038 problem.
> This patch makes grub able to support xfs filesystems with this feature
> enabled.
> 
> xfs counter for bigtime enable timestamps starts on 0, which translates
> to INT32_MIN (Dec 31 20:45:52 UTC 1901) in the legacy timestamps. The
> conversion to unix timestamps is made before passing the value to
> grub-core.
> 
> For this to work properly, grub requires to access flags2 field in the
> xfs ondisk inode, so, the grub_xfs_inode structure has been updated to
> the full ondisk inode size.
> 
> This patch is enough to make grub work properly with files with
> timestamps up to INT32_MAX (y2038), any file with timestamps bigger than
> this will overflow the counter, causing grub to show wrong timestamps
> (not really much difference on current situation).
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat