Re: [PATCH 1/2] MAINTAINERS: Add MAINTAINERS file

[Paul Menzel]

Dear Daniel,


Thank you for creating this

Am 01.06.21 um 18:13 schrieb Daniel Kiper:
> The MAINTAINERS file provides basic information about the GRUB project
> and its maintainers.
>
> Signed-off-by: Alex Burmashev <alexander.burmashev@oracle.com>
> Signed-off-by: Vladimir Serbinenko <phcoder@google.com>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
>   MAINTAINERS | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>   create mode 100644 MAINTAINERS
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> new file mode 100644
> index 000000000..41fdf5a04
> --- /dev/null
> +++ b/MAINTAINERS
> @@ -0,0 +1,31 @@
> +List of current GRUB maintainers and some basic information about the project
> +=============================================================================

In my opinion the basic information should go into the file `README`.

> +
> +Here is the list of current GRUB maintainers:
> +  - Daniel Kiper <daniel.kiper@oracle.com> and <dkiper@net-space.pl>,
> +  - Alex Burmashev <alexander.burmashev@oracle.com>,
> +  - Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>.
> +

My personal preference would be to remove the , and dot/period from the 
items [4].

> Capitalization and punctuation are optional when using single words
> or phrases in bulleted form. If each bullet or numbered point is a
> complete sentence, capitalize the first word and end each sentence
> with proper ending punctuation. The rule of thumb is to be
> consistent.


> +The maintainers drive and overlook the GRUB development.
> +
> +The GRUB development happens on the grub-devel mailing list [1]. The latest
> +GRUB source code is available at Savannah git repository [2].
> +
> +Users can ask for help on the help-grub mailing list [3].
> +
> +

As written above, I’d put the two paragraphs above in the file `README`.

> +List of past GRUB maintainers and people who strongly contributed to the 
> project
> +================================================================================
> +
> +Here is the list, sorted alphabetically, of past GRUB maintainers and people 
> who
> +strongly contributed to the project:
> +  - Andrei Borzenkov,
> +  - Bryan Ford,
> +  - Erich Stefan Boleyn,
> +  - Gordon Matzigkeit,
> +  - Yoshinori K. Okuji.
> +
> +
> +[1] https://lists.gnu.org/mailman/listinfo/grub-devel
> +[2] http://git.savannah.gnu.org/gitweb/?p=grub.git&view=view+git+repository

Why not the HTTPS URL?

> +[3] https://lists.gnu.org/mailman/listinfo/help-grub

Whatever you decide, you also might want to reference this file in the 
file `README` as other files are referenced there too.


Kind regards,

Paul


[4]: https://www.grammarbook.com/blog/colons/colons/