Re: [PATCH 00/12] Grub-shell improvements

[Daniel Kiper]

CC-ing Denis and Patrick...

On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote:
> Hi Daniel,
>
> On Thu, 26 Aug 2021 20:00:32 +0200
> Daniel Kiper <daniel.kiper@oracle.com> wrote:
>
> > Hi Glenn,
> >
> > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote:
> > > Hi Daniel,
> > >
> > > What are the chances this patch series can be reviewed in the near
> > > future? Some feedback would be greatly appreciated.
> >
> > I can see the following patches from you waiting in my review queue:
> >   - [CRYPTO-LUKS v1 00/19] Fixes and improvements for
> > cryptodisks+luks2 and a few other things.
> > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html
> >   - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount
> >     https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html
> >   - [PATCH 0/5] Testing improvements
> >     https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html
> >   - [CI 00/17] Gitlab CI and test framework improvements
> >     https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html
> >   - [PROCFS 0/5] Add and improve (proc) entries
> >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html
> >   - [PATCH 0/4] Various LUKS2 improvements
> >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html
> >   - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting
> >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html
> >   - [PATCH] fs: Allow number of blocks in block list to be optional,
> > defaulting length to device length
> > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html
> >   - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a
> > dash-insensitive manner
> > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html
> >   - [PATCH] command: Add silent mode to read command to suppress
> > input echo
> > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html
> >   - [PATCH 0/2] Allow overriding commands
> >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html
> >   - [PATCH 00/12] Grub-shell improvements
> >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html
> >   - [PATCH v2 0/8] Various fixes/improvements for tests
> >     https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html
> >   - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto
> > modules
> > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html
> >
> > Please sort them in the order of importance/preference/... Then I
> > will be looking at them (more or less) in that order, one patch set
> > at a time.
> >
> > I hope I did not miss any of your patches.
>
> As far as I can tell, this is the full list.

Great!

> My order preference is as follows:
>
> These two patches are only first because it should be a quick review.
>   - [PATCH] command: Add silent mode to read command to suppress
>     input echo
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html
>   - [PATCH] fs: Allow number of blocks in block list to be optional,
>     defaulting length to device length
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html

OK.

> This is a high priority because I think it should be merged before the
> keyfile and detached header support patch series. If this is merged,
> I'll submit and updated keyfile and detached header patch series that
> works with this patch series.
>   - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto
>     modules
>     https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html

Denis, Patrick, are you both OK with this?

> Based on discussion with Thomas Schmitt, I think the first patch of
> this series should be dropped. Should I make a v3, or would you review
> it and if acceptable drop the first patch?
>   - [PATCH v2 0/8] Various fixes/improvements for tests
>     https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html

No, you do not need to repost. I will take a look at v2 and ignore first
patch in it.

> Then these in this order.
>   - [PATCH 00/12] Grub-shell improvements
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html
>   - [PATCH 0/4] Various LUKS2 improvements
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html
>   - [PROCFS 0/5] Add and improve (proc) entries
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html
>   - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a
>     dash-insensitive manner
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html
>   - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html
>   - [PATCH 0/2] Allow overriding commands
>     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html
>
> ====================================================================
> Patch series with dependencies
>
> This patch series requires keyfile support via the -k argument for
> cryptomount. So it must be reviewed after a patch series implementing
> this. Also, iirc, this series relies on "Grub-shell improvements".
> Ideally this would get reviewed soon after its prerequisites get
> merged, so that we can be testing LUKS support. I'll probably also need
> to update it for changes, so let's hold off on this until I resubmit an
> updated version.
>   - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount
>     https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html
>
> ====================================================================
> Excluded/Discarded patch series
>
> I'm excluding the following patch series because most of it has already
> been accepted or is in one of the above patch series. So no need to
> review this one.
>   - [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2
>     and a few other things.
>     https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html
>
> Likewise this patch series is mostly a subset of "Various
> fixes/improvements for tests", and can be discarded.
>   - [PATCH 0/5] Testing improvements
>     https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html
>
> This patch series is the patch series "Testing improvements" combined
> with "Grub-shell improvements" with the CI patch on top. It makes sense
> to first deal with the patch series as separate, then the CI patch,
> which I'll submit at a later date. So let's ignore this one also.
>   - [CI 00/17] Gitlab CI and test framework improvements
>     https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html

Granted!

Daniel