[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/19] grub-shell: pseries: don't pass fw_opt to qemu
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 02/19] grub-shell: pseries: don't pass fw_opt to qemu |
Date: |
Wed, 20 Oct 2021 17:43:41 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Oct 12, 2021 at 01:57:43PM -0500, Glenn Washburn wrote:
> On Tue, 12 Oct 2021 18:29:51 +1100
> Daniel Axtens <dja@axtens.net> wrote:
>
> > At some point this started to break the test - qemu just rejects the
> > command line. Just don't pass it in, it's seabios specific.
> >
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
> > ---
> > tests/util/grub-shell.in | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
> > index 33590baeb13c..92c0b6f320c3 100644
> > --- a/tests/util/grub-shell.in
> > +++ b/tests/util/grub-shell.in
> > @@ -376,7 +376,11 @@ if test -z "$debug"; then
> > # workaround unfortunately causes qemu to issue a warning 'externally
> > # provided fw_cfg item names should be prefixed with "opt/"', but there
> > # doesn't seem to be a better option.
> > - qemuopts="${qemuopts} -fw_cfg name=etc/sercon-port,string=0"
> > + #
> > + # Don't do this on pseries, it breaks recent qemus.
> > + if [ $pseries == n ]; then
> > + qemuopts="${qemuopts} -fw_cfg name=etc/sercon-port,string=0"
>
> I've confirmed that this is an issue on Qemu 5.2 from Debian 11 and
> that this patch works as advertised. The better solution would only be
> added on targets using SeaBIOS. This would only be i386, right? There
> is an HPPA port, but I don't think we support that architecture.
Yeah, I agree, the sercon-port looks like the SeaBIOS specific thing.
Daniel A., could you rework the patch?
Daniel
- [PATCH 00/19] Requesting more memory from firmware, Daniel Axtens, 2021/10/12
- [PATCH 03/19] mm: document grub internal memory management structures, Daniel Axtens, 2021/10/12
- [PATCH 01/19] grub-shell: Boot PowerPC using PMU instead of CUDA for power management, Daniel Axtens, 2021/10/12
- [PATCH 04/19] mm: assert that we preserve header vs region alignment, Daniel Axtens, 2021/10/12
- [PATCH 02/19] grub-shell: pseries: don't pass fw_opt to qemu, Daniel Axtens, 2021/10/12
- [PATCH 05/19] mm: when adding a region, merge with region after as well as before, Daniel Axtens, 2021/10/12
- [PATCH 06/19] configure: properly pass through MM_DEBUG, Daniel Axtens, 2021/10/12
- [PATCH 07/19] Add memtool module with memory allocation stress-test, Daniel Axtens, 2021/10/12
- [PATCH 08/19] mm: Drop unused unloading of modules on OOM, Daniel Axtens, 2021/10/12
- [PATCH 10/19] efi: mm: Always request a fixed number of pages on init, Daniel Axtens, 2021/10/12
- [PATCH 12/19] efi: mm: Pass up errors from `add_memory_regions ()`, Daniel Axtens, 2021/10/12
- [PATCH 09/19] mm: Allow dynamically requesting additional memory regions, Daniel Axtens, 2021/10/12
- [PATCH 11/19] efi: mm: Extract function to add memory regions, Daniel Axtens, 2021/10/12