[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryp
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules |
Date: |
Mon, 20 Dec 2021 23:18:29 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Dec 09, 2021 at 11:14:55AM -0600, Glenn Washburn wrote:
> Previously, the cryptomount arguments were passed by global variable and
> function call argument, neither of which are ideal. This change passes data
> via a grub_cryptomount_args struct, which can be added to over time as
> opposed to continually adding arguments to the cryptodisk scan and
> recover_key.
>
> As an example, passing a password as a cryptomount argument is implemented.
> However, the backends are not implemented, so testing this will return a not
> implemented error.
>
> Also, add comments to cryptomount argument parsing to make it more obvious
> which argument states are being handled.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- Re: [PATCH v5 2/9] cryptodisk: Refactor to discard have_it global, (continued)
- [PATCH v5 4/9] cryptodisk: Improve error messaging in cryptomount invocations, Glenn Washburn, 2021/12/09
- [PATCH v5 3/9] cryptodisk: Return failure in cryptomount when no cryptodisk modules are loaded, Glenn Washburn, 2021/12/09
- [PATCH v5 5/9] cryptodisk: Improve cryptomount -u error message, Glenn Washburn, 2021/12/09
- [PATCH v5 7/9] cryptodisk: Refactor password input out of crypto dev modules into cryptodisk, Glenn Washburn, 2021/12/09
- [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules, Glenn Washburn, 2021/12/09
- Re: [PATCH v5 6/9] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules,
Daniel Kiper <=
- [PATCH v5 8/9] cryptodisk: Move global variables into grub_cryptomount_args struct, Glenn Washburn, 2021/12/09
- [PATCH v5 9/9] cryptodisk: Improve handling of partition name in cryptomount password prompt, Glenn Washburn, 2021/12/09
- Re: [PATCH v5 0/9] Refactor/improve cryptomount data passing to crypto modules, Daniel Kiper, 2021/12/20