Re: [PATCH v2 0/3] grub-probe: improve support of LUKS2

[Glenn Washburn]

On Tue, 29 Mar 2022 12:31:55 +0200
Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr> wrote:

> v2 updates:
>  * grub-fs-tester: remove extraneous 'sleep' and 'tail'
>  * add LUKS and LUKS2 fs tests
>  * the patches have been rebased on top of the master branch
> 
> 
> On 09/02/2022 07.20, Glenn Washburn wrote:
> > Why do this here instead of leaving this function alone and doing the
> > pipe and -C arg below when calling run_grubfstest?
> 
> I kept the changes within the run_it bash function because the
> run_grubfstest function is called many times and each call should have
> been updated. Do you prefer it changed everywhere?

No, it shouldn't be changed everywhere. I've addressed this further in
my comment on the grub-fs-tester patch.

Glenn

> 
> 
> Tested with:
> 
>   $ ./bootstrap && ./configure && make
>   $ make luks_test luks2_test
>   $ sudo ./luks_test
>   $ sudo ./luks2_test
> 
> Pierre-Louis Bonicoli (3):
>   grub-fs-tester: add luks1 and luks2 support
>   commands/probe: improve support of LUKS2 devices
>   grub-core/kern/disk.c: handle LUKS2 devices
> 
>  .gitignore                          |  2 ++
>  Makefile.util.def                   | 12 ++++++++
>  grub-core/kern/disk.c               |  4 ++-
>  grub-core/osdep/devmapper/getroot.c |  6 ++--
>  tests/luks2_test.in                 | 23 +++++++++++++++
>  tests/luks_test.in                  | 23 +++++++++++++++
>  tests/util/grub-fs-tester.in        | 46 +++++++++++++++++++++++++++--
>  7 files changed, 111 insertions(+), 5 deletions(-)
>  create mode 100644 tests/luks2_test.in
>  create mode 100644 tests/luks_test.in
>