Re: [PATCH] kern/efi: Log a console error during a stack check failure

[Glenn Washburn]

On Tue, 22 Mar 2022 18:05:29 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:

> On Mon, Mar 21, 2022 at 03:14:39PM +0000, Chris Coulson wrote:
> > The initial implementation of the stack protector just busy looped
> > in __stack_chk_fail in order to reduce the amount of code being
> > executed after the stack has been compromised because of a lack of
> > firmware memory protections. With future firmware implementations
> > incorporating memory protections such as W^X, call in to boot services
> > when an error occurs in order to log a message to the console before
> > automatically rebooting the machine.
> >
> > Signed-off-by: Chris Coulson <chris.coulson@canonical.com>
> 
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

I believe this is causing a build failure for arm64-efi with gcc 10.3.0, and
suspect this failure should occur on any gcc.

/builds/grub/grub-core/kern/efi/init.c:35:3: error: cannot initialize array of 
‘short unsigned int’ from a string literal with type array of ‘unsigned int’
   35 |   L"* GRUB: STACK SMASHING DETECTED!!! *\r\n"
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:36566: kern/efi/kernel_exec-init.o] Error 1

Glenn