[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fill_fs_info: pass pointer to dnode_end_t instead of value
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] fill_fs_info: pass pointer to dnode_end_t instead of value |
|
Date: |
Fri, 19 Aug 2022 18:42:39 +0200 |
On Fri, Aug 19, 2022 at 05:11:39PM +0200, Jag Raman wrote:
> > On Aug 19, 2022, at 11:09 AM, Darren Kenny <darren.kenny@oracle.com> wrote:
> >
> > Hi Jag,
> >
> > These changes look good to me.
> >
> > Just to confirm, you have run 'make check' and this has no negative
> > impact on the zfs tests?
>
> Hi Darren,
>
> Yes, I ran ‘make check’ and this patch had no negative impact on the ZFS test.
>
> >
> > Assuming that is the case...
> >
> > On Friday, 2022-08-19 at 10:57:22 -04, Jagannathan Raman wrote:
> >> Coverity reports that dnode_end_t argument of fill_fs_info() is too
> >> large to pass-by-value. Therefore, replace the argument with a pointer.
> >>
> >> Fixes: CID 73631
> >>
> >> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> >>
> >
> > Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel