Re: [PATCH 0/4] LUKS1/2 testing in fs-tester and LUKS2 support in grub-probe

[Patrick Steinhardt]

On Thu, Jan 12, 2023 at 05:05:06PM -0600, Glenn Washburn wrote:
> This series adds the testing of LUKS 1 and 2 encrypted container to the
> user-space fs tester. While this does replicate some of the testing done
> by grub_cmd_cryptomount, and is less flexible, it is run natively (that is
> without need for virtualization). It also tests the added LUKS2 support in
> grub-probe, unlike grub_cmd_cryptomount which does not test any user-space
> grub components.
> 
> All of these patches have previously been sent to the list. Only patch 4 has
> been slightly modified to fix some issues. Since utility of any one is greatly
> enhanced, and in the case of patch 4 required, by the others, I think it makes
> sense to evaluate them together.

Yeah, makes sense to have them all in one place.

> Fabian has noted a memory leak with error handling when using LUKS2 with a
> null_cipher[1]. Since this isn't something that I expect to happen in the wild
> (why would you use an unencrypted LUKS container?) and even if it does occur
> grub-probe is exiting, so the leak would be very short lived, I don't think
> this is something that we need to worry about. It wouldn't be that hard to fix
> though, just annoying and add a little more complexity to the source.
> 
> The corresponding patches can be found in the order of this series here:
>  1: [PATCH v3] disk/cryptodisk: When cheatmounting, use the sector info of 
> the cheat device
>     https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00106.html
>  2: [PATCH v6 1/2] devmapper/getroot: Have devmapper recognize LUKS2
>     https://lists.gnu.org/archive/html/grub-devel/2022-07/msg00036.html
>  3: [PATCH v6 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount 
> from DM parameters
>     https://lists.gnu.org/archive/html/grub-devel/2022-07/msg00038.html
>  4: [PATCH v4] grub-fs-tester: Add luks1 and luks2 support
>     https://lists.gnu.org/archive/html/grub-devel/2022-06/msg00127.html

For all patches:

    Reviewed-by: Patrick Steinhardt <ps@pks.im>

Thanks a bunch!

Patrick

signature.asc
Description: PGP signature