Re: [PATCH 0/6] NVMeoFC support on Grub

[Daniel Kiper]

On Mon, May 08, 2023 at 07:28:34PM +0530, Avnish Chouhan wrote:
> This patch series adds support of NVMeoFC on grub. It consists of six
> patches.
>
> Patch 1/6 (0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch):
> grub-ofpathname doesn't work with fibre channel because there is no
> function currently implemented for it.
> This patch enables it by prividing a function that looks for the port
> name, building the entire path for OF devices.
>
> Patch 2/6(0002-ieee1275-powerpc-enables-device-mapper-discovery.patch):
> This patch enables the device mapper discovery on ofpath.c. Currently,
> when we are dealing with a device like /dev/dm-* the ofpath returns null
> since there is no function implemented to handle this case.
> This patch implements a function that will look into /sys/block/dm-*
> devices and search recursively inside slaves directory to find the root
> disk.
>
> Patch 3/6(0003-ieee1275-implement-FCP-methods-for-WWPN-and-LUNs.patch):
> This patch enables the fcp-targets and fcp-luns methods which are
> responsible to get WWPNs and LUNs for fibre channel devices.
> Those methods are specially necessary if the boot directory and grub
> installation are in different FCP disks, allowing the dev_iterate()
> to find the WWPNs and LUNs when called by searchfs.uuid tool.
>
> Patch 4/6(0004-change-partition-parser.patch):
> Usually grub will parse the PFW arguments by searching for the first 
> occurence of the character ':'.
> However, we can have this char more than once on NQN.
> This patch changes the logic to find the last occurence of this char so we 
> can get the proper values
> for NVMeoFC
>
> Patch 5/6(0005-ieee1275-add-support-for-NVMeoFC.patch):
> This patch implements the functions to scan and discovery of NVMeoFC.
>
> Patch 6/6(0006-ieee1275-ofpath-enable-NVMeoF-logical-device-transla.patch):
> This patch add code to enable the translation of logical devices to the of 
> NVMeoFC paths.

We are nearing to the code freeze and I am stopping getting new features
which were not approved/reviewed by the GRUB maintainers earlier. So,
please do not except any reviews from me in the following weeks. Though
I will certainly will take a look at the series after the GRUB release...

Daniel