[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] lib/relocator: always enforce the requested alignment in
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v2] lib/relocator: always enforce the requested alignment in malloc_in_range() |
|
Date: |
Tue, 16 May 2023 15:24:25 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, May 12, 2023 at 09:33:55AM +0200, Roger Pau Monne via Grub-devel wrote:
> On failure to allocate from grub_relocator_firmware_alloc_region() in
> malloc_in_range() the function would stop enforcing the alignment, and
> the following was returned:
>
> lib/relocator.c:431: trying to allocate in 0x200000-0xffbf9fff aligned
> 0x200000 size 0x406000
> lib/relocator.c:1197: allocated: 0x74de2000+0x406000
> lib/relocator.c:1407: allocated 0x74de2000/0x74de2000
>
> Fix this by making sure that target always contains a suitably aligned
> address. After the change the return from the function is:
>
> lib/relocator.c:431: trying to allocate in 0x200000-0xffb87fff aligned
> 0x200000 size 0x478000
> lib/relocator.c:1204: allocated: 0x74c00000+0x478000
> lib/relocator.c:1414: allocated 0x74c00000/0x74c00000
>
> Fixes: 3a5768645c05 ('First version of allocation from firmware')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel