[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix for grub-switch-to-blscfg
From: |
Konstantin Vlasov |
Subject: |
Re: Fix for grub-switch-to-blscfg |
Date: |
Mon, 29 May 2023 19:08:08 +0300 |
Hi, Daniel.
>> We've discovered that there are some inconsistencies in the
>> grub-switch-to-blscfg tool, that lead to generating invalid BLS configs, when
>> /boot is not a separate partition.
>>
>> The attached patch fixes it.
>>
>>
>> P. S. There is also a secondary issue, which this patch also fixes: the
>> broken
>> "options" line generated by mkbls(). But it's automatically replaced with the
>> correct one by the subsequent call to "grub2-mkconfig" in the main code, so
>> it's
>> more for the purity of the code, rather than out of practical necessity.
> Thanks for the patch. Sadly the BLS support is not in the GRUB upstream
> yet. So, simply it will not apply. I suggest sending the patch to the
> GRUB maintainers of distro which you are using.
Oh, sorry, I didn't realize it could be a custom addition, and didn't check
with
the actual upstream repository. Indeed, it's added by a separate patch in the
RHEL package version which I was using.
I'll be more thorough next time.
--
Best regards,
Konstantin mailto:konstantin.vlasov@virtuozzo.com