[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1a] grub-emu: Add SDL2 support
From: |
Julian Andres Klode |
Subject: |
Re: [PATCH v1a] grub-emu: Add SDL2 support |
Date: |
Fri, 16 Jun 2023 13:55:28 +0200 |
On Fri, Jun 16, 2023 at 01:52:27PM +0200, Julian Andres Klode wrote:
> So all we did with the surface in SDL1 was split into window,
> surface, renderer, and texture. Instead of drawing into the
> surface and then flipping, you build your pixels, then update
> a texture, and then copy the texture to the renderer.
>
> Here we use an empty RGB surface to hold our Pixels, which enables
> us to keep most of the code the same. The SDL1 code has been adjusted
> to refer to `surface` instead of `window` when trying to access the
> properties of the surface.
>
> This approaches the configuration by adding a new --enable-grub-emu-sdl2
> argument. If set to yes, or auto detected, it disables SDL1 support
> automatically.
>
> This duplicates the `sdl` module block in Makefile.core.def which may
> be something to be aware of, but we also don't want to build separate
> module.
So now we have both approaches for configure.ac, I'm really not sure
what to prefer and leave it up to reviews.
--
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer i speak de, en