[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] docs: Add missing assumption
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 4/4] docs: Add missing assumption |
Date: |
Thu, 29 Jun 2023 20:06:02 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jun 28, 2023 at 10:20:29PM -0500, Oskari Pirhonen wrote:
> On Wed, Jun 28, 2023 at 05:10:10 -0500, Glenn Washburn wrote:
> > Also reword a prior sentence to be more clear.
> >
> > Fixes: 5a3d2b4742df (docs: Add debugging chapter to development
> > documentation)
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> > docs/grub-dev.texi | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi
> > index 72470b42c61a..a26171237d6a 100644
> > --- a/docs/grub-dev.texi
> > +++ b/docs/grub-dev.texi
> > @@ -660,10 +660,11 @@ GDB is started from the @file{grub-core} directory in
> > the GRUB2 build
> > directory. GRUB2 developers have made this more simple by including a GDB
> > script which does much of the setup. This file at @file{grub-core/gdb_grub}
> > of the build directory and is also installed via @command{make install}.
> > -If not building GRUB, the distribution may have a package which installs
> > +When using a pre-built GRUB, the distribution may have a package which
> > installs
> > this GDB script along with debug symbol binaries, such as Debian's
> > @samp{grub-pc-dbg} package. The GDB scripts is intended to by used
> > -like so, assuming:
> > +like so, assuming that @samp{/path/to/script} is the path to the directory
> > +containing the gdb_grub script and debug symbol files:
> >
> > @example
> > cd $(dirname /path/to/script/gdb_grub)
> > --
> > 2.34.1
> >
>
> This patch does not apply on top of my docs fixes from earlier. So one
> of us will have to rebase, depending on which patch goes in the tree
> first.
Oskari, your patch will go first.
Daniel
- [PATCH 0/4] Various corrections, Glenn Washburn, 2023/06/28
- [PATCH 1/4] misc: Fix typo, Glenn Washburn, 2023/06/28
- [PATCH 2/4] misc: Add space after comma in function argument list, Glenn Washburn, 2023/06/28
- [PATCH 3/4] docs: Minor corrections, Glenn Washburn, 2023/06/28
- [PATCH 4/4] docs: Add missing assumption, Glenn Washburn, 2023/06/28
- Re: [PATCH 0/4] Various corrections, Daniel Kiper, 2023/06/28