grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 02/11] Unify GUID types


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH v9 02/11] Unify GUID types
Date: Tue, 15 Aug 2023 05:42:43 +0200

.

Ard thinks that a 64 bit alignment for EFI GUIDs is a mistake - see [1]
and [2]. Hence Linux uses `__aligned(__alignof__(u32))` for "efi_guid_t"
since 2019.

My patch presents a reliability paradigm: accept all inputs, produce outputs that are always aligned to 8-byte. It can make sense even though I agree that requiring 8-byte alignment for UUID is weird. Yet it's difficult to know if some obscure firmware does rely on it in some one in a thousand edge case

[1]:
https://github.com/torvalds/linux/blob/master/include/linux/efi.h#L60-L78

[2]:
https://github.com/torvalds/linux/commit/494c704f9af0a0cddf593b381ea44320888733e6

I know I mentioned [1] earlier, but it sounds like it might have slipped
through and it might be a good idea to have both GRUB and Linux in sync
in this regard.

Cheers,
Frank

reply via email to

[Prev in Thread] Current Thread [Next in Thread]